Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow optional trailing comma in asset import.meta.url #6983

Merged
merged 4 commits into from Feb 22, 2022
Merged

fix: allow optional trailing comma in asset import.meta.url #6983

merged 4 commits into from Feb 22, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Feb 18, 2022

Description

fix #6978

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ydcjeff ydcjeff changed the title fix: add optional trailing comma in asset import.meta.url fix: allow optional trailing comma in asset import.meta.url Feb 18, 2022
@ydcjeff @bluwy
fix: allow whitespace characters after trailing comma
a1d6f7c 
add a new test

Co-authored-by: bluwy <bluwy@users.noreply.github.com>
@ydcjeff ydcjeff requested a review from bluwy February 18, 2022 12:08
@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 22, 2022
@patak-dev patak-dev merged commit 2debb9f into vitejs:main Feb 22, 2022
@ydcjeff ydcjeff deleted the fix/6978-import-meta-url-comma branch February 23, 2022 02:24
@developit developit mentioned this pull request Sep 22, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import.meta.url, with a comma at the end causes the build not to take effect
3 participants
@ydcjeff @patak-dev @bluwy