Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw Error when can't preload CSS #7108

Merged
merged 3 commits into from Mar 1, 2022
Merged

fix: throw Error when can't preload CSS #7108

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a848c7
fix: throw Error when can't preload CSS
sheremet-va Feb 27, 2022
594fadb
chore: linting PR
sheremet-va Feb 27, 2022
276fac1
Update packages/vite/src/node/plugins/importAnalysisBuild.ts
sheremet-va Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/vite/src/node/plugins/importAnalysisBuild.ts
View file
Open in desktop
Expand Up @@ -75,7 +75,9 @@ function preload(baseModule: () => Promise<{}>, deps?: string[]) {
if (isCss) {
return new Promise((res, rej) => {
link.addEventListener('load', res)
link.addEventListener('error', rej)
link.addEventListener('error', () =>
rej(new Error(`Unable to load CSS for ${dep}`))
)
Niputi marked this conversation as resolved.
Show resolved Hide resolved
sheremet-va marked this conversation as resolved.
Show resolved Hide resolved
})
}
})
Expand Down