Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: vite only replace __dirname, __filename, import.meta.url in cjs #7161

Merged
merged 4 commits into from Mar 19, 2022
Merged

docs: vite only replace __dirname, __filename, import.meta.url in cjs #7161

merged 4 commits into from Mar 19, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 3, 2022

Description

fix #6946

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added the documentation Improvements or additions to documentation label Mar 3, 2022
docs/config/index.md Outdated Show resolved Hide resolved
docs/config/index.md Outdated Show resolved Hide resolved
bluwy
bluwy previously approved these changes Mar 5, 2022
@ydcjeff
Copy link
Contributor Author

ydcjeff commented Mar 18, 2022

@patak-dev Can we merge this?

docs/config/index.md Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@patak-dev patak-dev merged commit f448593 into vitejs:main Mar 19, 2022
@ydcjeff ydcjeff deleted the docs/6946 branch March 19, 2022 06:21
@ShmuelMofrad
Copy link

Update Docs. please in Multi-Page App. There is still no update for __dirname in docs. Thanks.

@bluwy
Copy link
Member

bluwy commented Jul 16, 2022

Update Docs. please in Multi-Page App. There is still no update for __dirname in docs. Thanks.

fixed in #9121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"__dirname is not defined in ES module scope" in vite.config.js with module type in package.json
5 participants