Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit correct filename in windows #7192

Closed
wants to merge 1 commit into from

Conversation

DaPotatoMan
Copy link

@DaPotatoMan DaPotatoMan commented Mar 6, 2022

Description

Fixes wrong filename generation when building in windows
fix: #7191

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi changed the title fix: emit correct filename in windows (fix #7191) fix: emit correct filename in windows Mar 6, 2022
@j-maas j-maas mentioned this pull request Mar 19, 2022
9 tasks
@DaPotatoMan
Copy link
Author

Fixed by #7383

@DaPotatoMan DaPotatoMan deleted the fix-windows-path branch April 10, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong filename generated when building in Windows
1 participant