Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize the resolve logic of devServer's port and the server running at... log(#7271) #7274

Closed
wants to merge 1 commit into from

Conversation

libmw
Copy link

@libmw libmw commented Mar 11, 2022

…unning at... log(#7271)

Description

This PR is solving #7271 and #5241.

It will guarantee that the url displayed to the user is accessible.

In addition, when server.host is '' or 0 or other false value,it handles correctly .

Additional context

I'm not sure if this is a vite feature or a bug,and the code may not be particularly elegant.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

Closing as I believe this is mostly implemented by #8543, #8634, #8647 and the tests are failing and there is a conflict. If there is still any improvements please create a new issue or pr. Thank you.

@sapphi-red sapphi-red closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants