Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider undefined port when checking port #7318

Merged
merged 9 commits into from Mar 23, 2022
Merged

fix: consider undefined port when checking port #7318

merged 9 commits into from Mar 23, 2022

Commits on Mar 14, 2022

  1. fix: consider undefined port when checking port

    @benmccann
    benmccann committed Mar 14, 2022
    Copy the full SHA
    8a73ecf View commit details
    Browse the repository at this point in the history

  2. refactor: extract a few variables

    @benmccann
    benmccann committed Mar 14, 2022
    Copy the full SHA
    d3c4eb5 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. fix: lint

    @benmccann
    benmccann committed Mar 16, 2022
    Copy the full SHA
    7778a29 View commit details
    Browse the repository at this point in the history

  2. fix: can't switch order of variables

    @benmccann
    benmccann committed Mar 16, 2022
    Copy the full SHA
    975d9cd View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. chore: simplify

    @benmccann
    benmccann committed Mar 22, 2022
    Copy the full SHA
    aa1fc80 View commit details
    Browse the repository at this point in the history

  2. Revert "chore: simplify" 

    This reverts commit aa1fc80.
    @benmccann
    benmccann committed Mar 22, 2022
    Copy the full SHA
    053e01d View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. fix: update after review discussion

    @benmccann
    benmccann committed Mar 23, 2022
    Copy the full SHA
    64f2d07 View commit details
    Browse the repository at this point in the history

  2. fix: remove invalid check

    @benmccann
    benmccann committed Mar 23, 2022
    Copy the full SHA
    63c0282 View commit details
    Browse the repository at this point in the history

  3. chore: add TODO

    @benmccann
    benmccann committed Mar 23, 2022
    Copy the full SHA
    4c9f372 View commit details
    Browse the repository at this point in the history