Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add version to optimized chunks, fix #7323 #7350

Merged
merged 1 commit into from Mar 16, 2022
Merged

fix: add version to optimized chunks, fix #7323 #7350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/vite/src/node/plugins/importAnalysis.ts
View file
Open in desktop
Expand Up @@ -49,7 +49,6 @@ import { performance } from 'perf_hooks'
import { transformRequest } from '../server/transformRequest'
import {
isOptimizedDepFile,
createIsOptimizedDepUrl,
getDepsCacheDir,
optimizedDepNeedsInterop
} from '../optimizer'
Expand Down Expand Up @@ -114,14 +113,12 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
extensions: []
})
let server: ViteDevServer
let isOptimizedDepUrl: (url: string) => boolean

return {
name: 'vite:import-analysis',

configureServer(_server) {
server = _server
isOptimizedDepUrl = createIsOptimizedDepUrl(server.config)
},

async transform(source, importer, options) {
Expand Down Expand Up @@ -274,11 +271,7 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
// (e.g. vue blocks), inherit importer's version query
// do not do this for unknown type imports, otherwise the appended
// query can break 3rd party plugin's extension checks.
if (
(isRelative || isSelfImport) &&
!(isOptimizedDepUrl(url) && optimizedDepChunkRE.test(url)) &&
!/[\?&]import=?\b/.test(url)
) {
if ((isRelative || isSelfImport) && !/[\?&]import=?\b/.test(url)) {
const versionMatch = importer.match(DEP_VERSION_RE)
if (versionMatch) {
url = injectQuery(url, versionMatch[1])
Expand Down