Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide optimized deps found during scan phase logs #7419

Merged
merged 6 commits into from Mar 24, 2022
Merged

feat: hide optimized deps found during scan phase logs #7419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
57dd4a4
feat: hide optimized deps logs
patak-dev Mar 23, 2022
18f9170
chore: update
patak-dev Mar 23, 2022
1163514
chore: wording
patak-dev Mar 23, 2022
f52eb15
chore: wording
patak-dev Mar 24, 2022
2a9aa7d
chore: log feedback for --force
patak-dev Mar 24, 2022
7c05c40
chore: format
patak-dev Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/vite/src/node/optimizer/index.ts
View file
Open in desktop
Expand Up @@ -253,6 +253,8 @@ export function loadCachedDepOptimizationMetadata(
// need to resolve the processing promise so requests can move on
return cachedMetadata
}
} else {
config.logger.info('Forced re-optimization of dependencies')
patak-dev marked this conversation as resolved.
Show resolved Hide resolved
}

// Start with a fresh cache
Expand Down
59 changes: 32 additions & 27 deletions packages/vite/src/node/optimizer/registerMissing.ts
View file
Open in desktop
Expand Up @@ -47,14 +47,18 @@ export function createOptimizedDeps(server: ViteDevServer): OptimizedDeps {

let newDepsToLog: string[] = []
let newDepsToLogHandle: NodeJS.Timeout | undefined
const logNewDeps = () => {
config.logger.info(
colors.green(`✨ dependencies optimized: ${depsLogString(newDepsToLog)}`),
{
timestamp: true
}
)
newDepsToLog = []
const logNewlyDiscoveredDeps = () => {
if (newDepsToLog.length) {
config.logger.info(
colors.green(
`✨ new dependencies optimized: ${depsLogString(newDepsToLog)}`
),
{
timestamp: true
}
)
newDepsToLog = []
}
}

let depOptimizationProcessing = newDepOptimizationProcessing()
Expand Down Expand Up @@ -124,7 +128,7 @@ export function createOptimizedDeps(server: ViteDevServer): OptimizedDeps {
setTimeout(warmUp, 0)
}

async function runOptimizer() {
async function runOptimizer(isRerun = false) {
// Ensure that rerun is called sequentially
enqueuedRerun = undefined
currentlyProcessing = true
Expand Down Expand Up @@ -223,11 +227,13 @@ export function createOptimizedDeps(server: ViteDevServer): OptimizedDeps {
}
}

newDepsToLog.push(
...Object.keys(newData.optimized).filter(
(dep) => !metadata.optimized[dep]
if (isRerun) {
newDepsToLog.push(
...Object.keys(newData.optimized).filter(
(dep) => !metadata.optimized[dep]
)
)
)
}

metadata = optimizedDeps.metadata = newData
resolveEnqueuedProcessingPromises()
Expand All @@ -236,17 +242,16 @@ export function createOptimizedDeps(server: ViteDevServer): OptimizedDeps {
if (!needsReload) {
commitProcessing()

if (isDebugEnabled) {
logNewDeps()
debug(colors.green(`✨ previous optimized dependencies unchanged`), {
timestamp: true
})
} else {
if (!isDebugEnabled) {
if (newDepsToLogHandle) clearTimeout(newDepsToLogHandle)
newDepsToLogHandle = setTimeout(() => {
newDepsToLogHandle = undefined
logNewDeps()
logNewlyDiscoveredDeps()
}, 2 * debounceMs)
} else {
debug(colors.green(`✨ optimized dependencies unchanged`), {
timestamp: true
})
}
} else {
if (newDepsDiscovered) {
Expand All @@ -267,14 +272,14 @@ export function createOptimizedDeps(server: ViteDevServer): OptimizedDeps {
} else {
commitProcessing()

if (newDepsToLogHandle) clearTimeout(newDepsToLogHandle)
newDepsToLogHandle = undefined
logNewDeps()
if (!isDebugEnabled) {
if (newDepsToLogHandle) clearTimeout(newDepsToLogHandle)
newDepsToLogHandle = undefined
logNewlyDiscoveredDeps()
}

logger.info(
colors.green(
`✨ previous optimized dependencies have changed, reloading page`
),
colors.green(`✨ optimized dependencies changed. reloading`),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use a different emoji for this one. Like 🔄 or ⚙️. Not convinced by other options, probably better to keep the current one

{
timestamp: true
}
Expand Down Expand Up @@ -320,7 +325,7 @@ export function createOptimizedDeps(server: ViteDevServer): OptimizedDeps {
debug(colors.green(`new dependencies found: ${depsString}`), {
timestamp: true
})
runOptimizer()
runOptimizer(true)
}

function getDiscoveredBrowserHash(
Expand Down