Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert optimizeDeps false, keep optimizedDeps.disabled #7715

Merged
merged 2 commits into from Apr 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/playground/vue-jsx/vite.config.js
Expand Up @@ -36,5 +36,7 @@ export default defineComponent(() => {
// to make tests faster
minify: false
},
optimizeDeps: false
optimizeDeps: {
disabled: true
}
}
5 changes: 1 addition & 4 deletions packages/vite/src/node/config.ts
Expand Up @@ -145,10 +145,8 @@ export interface UserConfig {
preview?: PreviewOptions
/**
* Dep optimization options
*
* false disables optimization completely (experimental)
*/
optimizeDeps?: DepOptimizationOptions | false
optimizeDeps?: DepOptimizationOptions
/**
* SSR specific options
* @alpha
Expand Down Expand Up @@ -501,7 +499,6 @@ export async function resolveConfig(
packageCache: new Map(),
createResolver,
optimizeDeps: {
disabled: config.optimizeDeps === false,
...optimizeDeps,
esbuildOptions: {
keepNames: optimizeDeps.keepNames,
Expand Down