Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix properly use terser for preload test #7771

Merged
merged 1 commit into from Apr 17, 2022

Conversation

sapphi-red
Copy link
Member

Description

build.terserOptions was set for #4163 but build.minify was not set.
This PR simply adds minify: 'terser'.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added test p1-chore Doesn't change code behavior (priority) labels Apr 17, 2022
@sapphi-red sapphi-red changed the title test: fix use terser for preload test test: fix properly use terser for preload test Apr 17, 2022
@patak-dev patak-dev merged commit 694c1ce into vitejs:main Apr 17, 2022
@sapphi-red sapphi-red deleted the test/fix-preload-minify branch April 17, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants