Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure @rollup/plugin-commonjs v22 update builds correctly #7892

Conversation

fwouts
Copy link
Contributor

@fwouts fwouts commented Apr 24, 2022

Description

This PR, which isn't meant to be merged into main directly, fixes the build failures seen in #7886.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@fwouts
Copy link
Contributor Author

fwouts commented Apr 25, 2022

Not sure why these failing tests didn't pop up in my local run, I'll fix this up.

@fwouts
Copy link
Contributor Author

fwouts commented Apr 25, 2022

Test failures appear due to the Rollup upgrade. As far as I understand, the vite:modulepreload-polyfill plugin is now, in some cases (HMR in particular?) unable to catch the load event. I'll explore further, but I'll close this PR for now as it's clearly not ready.

Edit: in fact, it was probably because I replaced loadResult == null with !loadResult :)

@fwouts fwouts closed this Apr 25, 2022
@fwouts fwouts deleted the renovate/rollup-plugin-commonjs-22.x branch April 25, 2022 03:10
@fwouts fwouts restored the renovate/rollup-plugin-commonjs-22.x branch April 25, 2022 03:10
@fwouts fwouts deleted the renovate/rollup-plugin-commonjs-22.x branch April 25, 2022 03:10
@fwouts fwouts restored the renovate/rollup-plugin-commonjs-22.x branch April 25, 2022 03:10
@fwouts fwouts deleted the renovate/rollup-plugin-commonjs-22.x branch April 25, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant