Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set status code 200 to /__vite_ping #8128

Closed

Conversation

wangjianio
Copy link
Contributor

Description

When use vite as a middleware, the default status code returned by /__vite_ping is 404, causes the browser to fail to reconnect after server restart.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Thanks for the PR, but we actually need to remove the middleware. See #6819, it isn't going to be used anymore. We forgot to do it in 6819. If you would like, you can remove it in this PR and we merge it here.

@wangjianio wangjianio closed this May 12, 2022
@wangjianio
Copy link
Contributor Author

Thanks for the PR, but we actually need to remove the middleware. See #6819, it isn't going to be used anymore. We forgot to do it in 6819. If you would like, you can remove it in this PR and we merge it here.

@patak-dev #8133 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants