Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support set NODE_ENV in scripts when custom mode option #8218

Merged
merged 3 commits into from May 23, 2022
Merged

fix: support set NODE_ENV in scripts when custom mode option #8218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da26930
feat: support set NODE_ENV in scripts
Dunqing May 19, 2022
7c39314
fix: vitest set NODE_ENV causes the test to fail
Dunqing May 20, 2022
120c091
docs: add comment
Dunqing May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/vite/src/node/config.ts
View file
Open in desktop
Expand Up @@ -395,7 +395,9 @@ export async function resolveConfig(
// Note it is possible for user to have a custom mode, e.g. `staging` where
// production-like behavior is expected. This is indicated by NODE_ENV=production
// loaded from `.staging.env` and set by us as VITE_USER_NODE_ENV
const isProduction = (process.env.VITE_USER_NODE_ENV || mode) === 'production'
const isProduction =
(process.env.NODE_ENV || process.env.VITE_USER_NODE_ENV || mode) ===
'production'
if (isProduction) {
// in case default mode was not production and is overwritten
process.env.NODE_ENV = 'production'
Expand Down
3 changes: 3 additions & 0 deletions playground/optimize-deps/vite.config.js
View file
Open in desktop
@@ -1,6 +1,9 @@
const fs = require('fs')
const vue = require('@vitejs/plugin-vue')

// Overriding the NODE_ENV set by vitest
process.env.NODE_ENV = ''
bluwy marked this conversation as resolved.
Show resolved Hide resolved

/**
* @type {import('vite').UserConfig}
*/
Expand Down