Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): should reload, if some files outside the module graph are changed #8273

Closed
wants to merge 1 commit into from

Conversation

TrickyPi
Copy link
Contributor

@TrickyPi TrickyPi commented May 22, 2022

Description

closes: #7024

Additional context

test already exists? https://github.com/vitejs/vite/blob/main/playground/hmr/__tests__/hmr.spec.ts#L216


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@TrickyPi
Copy link
Contributor Author

TrickyPi commented May 22, 2022

Default reloading doesn't seem to be compatible with custom HMR update handling when some files outside of the module graph are changed.

@sapphi-red
Copy link
Member

Closing as #9723 superseded this.

@sapphi-red sapphi-red closed this Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addWatchFile can not be used to watch files outside of the module graph
2 participants