Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use typescript for rollup configPlugin #8290

Merged
merged 1 commit into from May 23, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 23, 2022

Description

Use @rollup/plugin-typescript as --configPlugin for rollup, instead of rollup-plugin-esbuild

Additional context

Mentioned at #8178 (comment)

Note: I have to add @rollup/plugin-typescript and tslib as workspace deps in order for Rollup to import them (for some reason). This shouldn't increase the local dev install size as they are devDeps of vite too.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label May 23, 2022
@patak-dev patak-dev merged commit fa538cf into vitejs:main May 23, 2022
@bluwy bluwy deleted the chore-rollup-typescript branch May 23, 2022 14:13
@bluwy bluwy mentioned this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants