Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename force to optimizeDeps.force #8418

Merged
merged 4 commits into from Jun 17, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/config/dep-optimization-options.md
Expand Up @@ -45,3 +45,9 @@ Certain options are omitted since changing them would not be compatible with Vit

- `external` is also omitted, use Vite's `optimizeDeps.exclude` option
- `plugins` are merged with Vite's dep plugin

## optimizeDeps.force

- **Type:** `boolean`

Set to `true` to force dependency pre-bundling.
sapphi-red marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 0 additions & 7 deletions docs/config/server-options.md
Expand Up @@ -107,13 +107,6 @@ Configure CORS for the dev server. This is enabled by default and allows any ori

Specify server response headers.

## server.force

- **Type:** `boolean`
- **Related:** [Dependency Pre-Bundling](/guide/dep-pre-bundling)

Set to `true` to force dependency pre-bundling.

## server.hmr

- **Type:** `boolean | { protocol?: string, host?: string, port?: number, path?: string, timeout?: number, overlay?: boolean, clientPort?: number, server?: Server }`
Expand Down
2 changes: 1 addition & 1 deletion docs/guide/migration.md
Expand Up @@ -116,7 +116,7 @@ Also there are other breaking changes which only affect few users.
- [[#8090] feat: preserve process env vars in lib build](https://github.com/vitejs/vite/pull/8090)
- `process.env.*` is now preserved in library mode
- [[#8280] feat: non-blocking esbuild optimization at build time](https://github.com/vitejs/vite/pull/8280)
- `server.force` option was removed in favor of `force` option.
- `server.force` option was removed in favor of `optimizeDeps.force` option.
- [[#8550] fix: dont handle sigterm in middleware mode](https://github.com/vitejs/vite/pull/8550)
- When running in middleware mode, Vite no longer kills process on `SIGTERM`.

Expand Down
3 changes: 2 additions & 1 deletion packages/vite/src/node/cli.ts
Expand Up @@ -87,6 +87,7 @@ cli
configFile: options.config,
logLevel: options.logLevel,
clearScreen: options.clearScreen,
optimizeDeps: { force: options.force },
server: cleanOptions(options)
})

Expand Down Expand Up @@ -174,7 +175,7 @@ cli
configFile: options.config,
logLevel: options.logLevel,
clearScreen: options.clearScreen,
force: options.force,
optimizeDeps: { force: options.force },
build: buildOptions
})
} catch (e) {
Expand Down
5 changes: 0 additions & 5 deletions packages/vite/src/node/config.ts
Expand Up @@ -146,11 +146,6 @@ export interface UserConfig {
* Preview specific options, e.g. host, port, https...
*/
preview?: PreviewOptions
/**
* Force dep pre-optimization regardless of whether deps have changed.
* @experimental
*/
force?: boolean
/**
* Dep optimization options
*/
Expand Down
9 changes: 7 additions & 2 deletions packages/vite/src/node/optimizer/index.ts
Expand Up @@ -137,6 +137,11 @@ export interface DepOptimizationOptions {
* @experimental
*/
disabled?: boolean | 'build' | 'dev'
/**
* Force dep pre-optimization regardless of whether deps have changed.
* @experimental
*/
force?: boolean
}

export interface DepOptimizationResult {
Expand Down Expand Up @@ -209,7 +214,7 @@ export interface DepOptimizationMetadata {
*/
export async function optimizeDeps(
config: ResolvedConfig,
force = config.force,
force = config.optimizeDeps.force,
asCommand = false
): Promise<DepOptimizationMetadata> {
const log = asCommand ? config.logger.info : debug
Expand Down Expand Up @@ -265,7 +270,7 @@ export function addOptimizedDepInfo(
*/
export function loadCachedDepOptimizationMetadata(
config: ResolvedConfig,
force = config.force,
force = config.optimizeDeps.force,
asCommand = false
): DepOptimizationMetadata | undefined {
const log = asCommand ? config.logger.info : debug
Expand Down