Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SSR deep imports externalization (fixes #8420) #8421

Merged
merged 2 commits into from Jun 1, 2022
Merged

fix: SSR deep imports externalization (fixes #8420) #8421

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac8c233
fix: respect package.exports when resolving SSR deep imports
patak-dev May 31, 2022
054dbe7
fix: don't externalize .css deep imports
patak-dev May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/vite/src/node/plugins/resolve.ts
View file
Open in desktop
Expand Up @@ -636,8 +636,14 @@ export function tryNodeResolve(
return resolved
}
const resolvedExt = path.extname(resolved.id)
const resolvedId =
isDeepImport && path.extname(id) !== resolvedExt ? id + resolvedExt : id
let resolvedId = id
if (
isDeepImport &&
!pkg?.data.exports &&
path.extname(id) !== resolvedExt
) {
resolvedId += resolvedExt
}
return { ...resolved, id: resolvedId, external: true }
}

Expand Down