Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont handle sigterm in middleware mode #8550

Merged
merged 3 commits into from Jun 12, 2022
+16 −16
Merged

fix: dont handle sigterm in middleware mode #8550

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ba7469
fix: dont handle sigterm in middleware mode
bluwy Jun 12, 2022
e331cb8
fix: catch sigterm in ci
bluwy Jun 12, 2022
b54b2d9
chore: fix typo
bluwy Jun 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 9 additions & 13 deletions packages/vite/src/node/server/index.ts
View file
Open in desktop
Expand Up @@ -299,7 +299,6 @@ export async function createServer(
const container = await createPluginContainer(config, moduleGraph, watcher)
const closeHttpServer = createServerCloseFn(httpServer)

// eslint-disable-next-line prefer-const
let exitProcess: () => void

const server: ViteDevServer = {
Expand Down Expand Up @@ -342,9 +341,8 @@ export async function createServer(
return startServer(server, port, isRestart)
},
async close() {
process.off('SIGTERM', exitProcess)

if (!middlewareMode && process.env.CI !== 'true') {
process.off('SIGTERM', exitProcess)
process.stdin.off('end', exitProcess)
}

Expand Down Expand Up @@ -382,17 +380,15 @@ export async function createServer(

server.transformIndexHtml = createDevHtmlTransformFn(server)

exitProcess = async () => {
try {
await server.close()
} finally {
process.exit()
}
}

process.once('SIGTERM', exitProcess)

if (!middlewareMode && process.env.CI !== 'true') {
exitProcess = async () => {
try {
await server.close()
} finally {
process.exit()
}
}
process.once('SIGTERM', exitProcess)
bluwy marked this conversation as resolved.
Show resolved Hide resolved
process.stdin.on('end', exitProcess)
}

Expand Down