Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default export module transformation for vitest spy #8567

Merged
merged 2 commits into from Jun 13, 2022
Merged

fix: default export module transformation for vitest spy #8567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461714a
fix: default export module transformation for vitest spy
konpeki622 Jun 13, 2022
65d0562
fix: update snapshot
konpeki622 Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts
View file
Open in desktop
Expand Up @@ -306,7 +306,7 @@ test('should declare variable for imported super class', async () => {
class A extends Foo {}
class B extends Foo {}
Object.defineProperty(__vite_ssr_exports__, \\"B\\", { enumerable: true, configurable: true, get(){ return B }});
Object.defineProperty(__vite_ssr_exports__, \\"default\\", { enumerable: true, value: A });"
Object.defineProperty(__vite_ssr_exports__, \\"default\\", { enumerable: true, configurable: true, value: A });"
`)
})

Expand Down Expand Up @@ -338,7 +338,7 @@ test('should handle default export variants', async () => {
).toMatchInlineSnapshot(`
"function foo() {}
foo.prototype = Object.prototype;
Object.defineProperty(__vite_ssr_exports__, \\"default\\", { enumerable: true, value: foo });"
Object.defineProperty(__vite_ssr_exports__, \\"default\\", { enumerable: true, configurable: true, value: foo });"
`)
// default named classes
expect(
Expand All @@ -353,7 +353,7 @@ test('should handle default export variants', async () => {
"class A {}
class B extends A {}
Object.defineProperty(__vite_ssr_exports__, \\"B\\", { enumerable: true, configurable: true, get(){ return B }});
Object.defineProperty(__vite_ssr_exports__, \\"default\\", { enumerable: true, value: A });"
Object.defineProperty(__vite_ssr_exports__, \\"default\\", { enumerable: true, configurable: true, value: A });"
`)
})

Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/ssr/ssrTransform.ts
View file
Open in desktop
Expand Up @@ -188,7 +188,7 @@ async function ssrTransformScript(
s.remove(node.start, node.start + 15 /* 'export default '.length */)
s.append(
`\nObject.defineProperty(${ssrModuleExportsKey}, "default", ` +
`{ enumerable: true, value: ${name} });`
`{ enumerable: true, configurable: true, value: ${name} });`
)
} else {
// anonymous default exports
Expand Down