Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): browser field bare import #8709

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 22, 2022

Description

based on #8706

See #7599 for why these did not work.

close #7599 (this PR includes it)
fixes #4798: another error happens but updating socket.io-client to 4.3.0+ will fix.

[plugin vite:dep-pre-bundle] Missing "./wrapper.mjs" export in "socket.io-client" package
    dep:socket__io-client:1:14:
      1 │ import d from "./node_modules/socket.io-client/wrapper.mjs";export default d;

fixes #7301
fixes #7576

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 22, 2022
@netlify
Copy link

netlify bot commented Jun 22, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit e1bace7
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b2c67f5b43d300098f5463
😎 Deploy Preview https://deploy-preview-8709--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cameronbraid
Copy link

Any chance that this can be progressed ?

@sapphi-red
Copy link
Member Author

Closing for now as this PR needs to solve #8706 (comment) first.

@sapphi-red sapphi-red closed this Sep 7, 2022
@sapphi-red sapphi-red deleted the fix/optimizer-browser-field-bare-import branch April 20, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
2 participants