Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: update rollup commonjs plugin to v22 #8743

Merged
merged 13 commits into from Jun 24, 2022
Merged

chore!: update rollup commonjs plugin to v22 #8743

merged 13 commits into from Jun 24, 2022

Commits on Jun 23, 2022

  1. chore: update commonjs plugin to v22 and make build work 

    Well, the built bundle doesn't work yet.
Blocked by rollup/plugins#1180
    @sodatea
    sodatea committed Jun 23, 2022
    Copy the full SHA
    31c6fd8 View commit details
    Browse the repository at this point in the history

  2. build: resolve import.meta.url at build time

    @sodatea
    sodatea committed Jun 23, 2022
    Copy the full SHA
    0ff13b4 View commit details
    Browse the repository at this point in the history

  3. fix: exclude ts-node from bundle

    @sapphi-red @sodatea
    sapphi-red authored and sodatea committed Jun 23, 2022
    Copy the full SHA
    a90d1fb View commit details
    Browse the repository at this point in the history

  4. build: use pathToFileURL to support Windows paths

    @sodatea
    sodatea committed Jun 23, 2022
    Copy the full SHA
    14e7ec9 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. chore: update commonjs plugin to v22.0.1

    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    03502a3 View commit details
    Browse the repository at this point in the history

  2. test: add tests for legacy cjs plugin

    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    2d2b0fb View commit details
    Browse the repository at this point in the history

  3. test: add commonjsOptions to the external test 

    …so that it can correctly transpile `require` to `import *`
    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    4cc55cf View commit details
    Browse the repository at this point in the history

  4. test: fix env var name 😅

    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    d2a1c82 View commit details
    Browse the repository at this point in the history

  5. ci: add cjs test to CI workflow

    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    7202161 View commit details
    Browse the repository at this point in the history

  6. test: should apply the test config before resolving…

    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    5c264f8 View commit details
    Browse the repository at this point in the history

  7. test: use the correct id of browserExternalId 

    In production there's no `:fs` suffix
https://github.com/vitejs/vite/blob/32712668f6586734afa592384e325e9a8b528fe9/packages/vite/src/node/plugins/resolve.ts#L328-L330
    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    4234d7a View commit details
    Browse the repository at this point in the history

  8. test: skip the esbuild-plugin test when testing the rollup cjs plugin

    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    a81c64f View commit details
    Browse the repository at this point in the history

  9. ci: remove cjs plugin test from the main CI tests 

    We'll move it to the ecosystem-ci instead
    @sodatea
    sodatea committed Jun 24, 2022
    Copy the full SHA
    0a36140 View commit details
    Browse the repository at this point in the history