feat: respect esbuild minify config

docs/config/build-options.md

@@ -145,7 +145,7 @@ Produce SSR-oriented build. The value can be a string to directly specify the SS
 
 Set to `false` to disable minification, or specify the minifier to use. The default is [esbuild](https://github.com/evanw/esbuild) which is 20 ~ 40x faster than terser and only 1 ~ 2% worse compression. [Benchmarks](https://github.com/privatenumber/minification-benchmarks)
 
-Note the `build.minify` option is not available when using the `'es'` format in lib mode.
+Note the `build.minify` option does not minify whitespaces when using the `'es'` format in lib mode, as it removes pure annotations and break tree-shaking.
 
 Terser must be installed when it is set to `'terser'`.
 

docs/config/shared-options.md

@@ -280,6 +280,8 @@ export default defineConfig({
 })
 ```
 
+When `build.minify` is `true`, you can configure to only minify certain aspects of the code by setting either of `esbuild.minifyIdentifiers`, `esbuild.minifySyntax`, and `esbuild.minifyWhitespace` to `true`. Note the `esbuild.minify` option can't be used to override `build.minify`.
+
 Set to `false` to disable esbuild transforms.
 
 ## assetsInclude

packages/vite/src/node/plugins/esbuild.ts

@@ -37,6 +37,10 @@ export interface ESBuildOptions extends TransformOptions {
   include?: string | RegExp | string[] | RegExp[]
   exclude?: string | RegExp | string[] | RegExp[]
   jsxInject?: string
+  /**
+   * This option is not respected. Use `build.minify` instead.
+   */
+  minify?: never
 }
 
 export type ESBuildTransformResult = Omit<TransformResult, 'map'> & {
@@ -170,6 +174,17 @@ export function esbuildPlugin(options: ESBuildOptions = {}): Plugin {
     options.exclude || /\.js$/
   )
 
+  // Remove optimization options for dev as we only need to transpile them,
+  // and for build as the final optimization is in `buildEsbuildPlugin`
+  const transformOptions: TransformOptions = {
+    ...options,
+    minify: false,
+    minifyIdentifiers: false,
+    minifySyntax: false,
+    minifyWhitespace: false,
+    treeShaking: false
+  }
+
   return {
     name: 'vite:esbuild',
     configureServer(_server) {
@@ -188,7 +203,7 @@ export function esbuildPlugin(options: ESBuildOptions = {}): Plugin {
     },
     async transform(code, id) {
       if (filter(id) || filter(cleanUrl(id))) {
-        const result = await transformWithEsbuild(code, id, options)
+        const result = await transformWithEsbuild(code, id, transformOptions)
         if (result.warnings.length) {
           result.warnings.forEach((m) => {
             this.warn(prettifyMessage(m, code))
@@ -243,20 +258,55 @@ export const buildEsbuildPlugin = (config: ResolvedConfig): Plugin => {
         return null
       }
 
-      const res = await transformWithEsbuild(code, chunk.fileName, {
+      const isEsLibBuild = config.build.lib && opts.format === 'es'
+      let options: TransformOptions = {
         ...config.esbuild,
         target: target || undefined,
-        ...(minify
-          ? {
-              // Do not minify ES lib output since that would remove pure annotations
-              // and break tree-shaking
-              // https://github.com/vuejs/core/issues/2860#issuecomment-926882793
-              minify: !(config.build.lib && opts.format === 'es'),
-              treeShaking: true,
-              format: rollupToEsbuildFormatMap[opts.format]
-            }
-          : undefined)
-      })
+        format: rollupToEsbuildFormatMap[opts.format]
+      }
+
+      if (minify) {
+        // If user enable fine-grain minify options, minify with their options instead
+        if (
+          options.minifyIdentifiers === true ||
+          options.minifySyntax === true ||
+          options.minifyWhitespace === true
+        ) {
+          options = { ...options, treeShaking: true }
+          // Do not minify whitespace for ES lib output since that would remove
+          // pure annotations and break tree-shaking
+          // https://github.com/vuejs/core/issues/2860#issuecomment-926882793
+          if (isEsLibBuild) {
+            options = { ...options, minifyWhitespace: true }
+          }
+        } else if (isEsLibBuild) {
+          // Enable all minify except whitespace, which doesn't work
+          options = {
+            ...options,
+            minify: false,
+            minifyIdentifiers: true,
+            minifySyntax: true,
+            treeShaking: true
+          }
+        } else {
+          options = {
+            ...options,
+            minify: true,
+            treeShaking: true
+          }
+        }
+      } else {
+        options = {
+          ...options,
+          minify: false,
+          minifyIdentifiers: false,
+          minifySyntax: false,
+          minifyWhitespace: false,
+          treeShaking: false
+        }
+      }
+
+      const res = await transformWithEsbuild(code, chunk.fileName, options)
 
       if (config.build.lib) {
         // #7188, esbuild adds helpers out of the UMD and IIFE wrappers, and the