Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid sourcemap chains during dev #8796

Merged
merged 8 commits into from Jun 26, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/vite/src/node/plugins/define.ts
@@ -1,7 +1,7 @@
import MagicString from 'magic-string'
import type { TransformResult } from 'rollup'
import type { ResolvedConfig } from '../config'
import type { Plugin } from '../plugin'
import { transformStableResult } from '../utils'
import { isCSSRequest } from './css'
import { isHTMLRequest } from './html'

Expand Down Expand Up @@ -144,11 +144,7 @@ export function definePlugin(config: ResolvedConfig): Plugin {
return null
}

const result: TransformResult = { code: s.toString() }
if (config.build.sourcemap) {
result.map = s.generateMap({ hires: true })
}
return result
return transformStableResult(s, id, config)
}
}
}
8 changes: 3 additions & 5 deletions packages/vite/src/node/plugins/importAnalysisBuild.ts
Expand Up @@ -10,7 +10,8 @@ import {
combineSourcemaps,
isDataUrl,
isExternalUrl,
moduleListContains
moduleListContains,
transformStableResult
patak-dev marked this conversation as resolved.
Show resolved Hide resolved
} from '../utils'
import type { Plugin } from '../plugin'
import type { ResolvedConfig } from '../config'
Expand Down Expand Up @@ -314,10 +315,7 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {
}

if (s) {
return {
code: s.toString(),
map: config.build.sourcemap ? s.generateMap({ hires: true }) : null
}
return transformStableResult(s, importer, config)
patak-dev marked this conversation as resolved.
Show resolved Hide resolved
patak-dev marked this conversation as resolved.
Show resolved Hide resolved
}
},

Expand Down