Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add package.json to export map #8838

Merged
merged 1 commit into from Jun 28, 2022

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Jun 28, 2022

Description

We've only exposed the version field since #8456
Before that, users can only get the version number from package.json.

This fixes compatibility issue with iles:
https://github.com/ElMassimo/iles/blob/4618f4be7118c06324d74d87d35ba73c0767369b/packages/iles/src/node/cli.ts#L11

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

We've only exposed the `version` field since vitejs#8456
Before that, users can only get the version number from `package.json`.

This fixes compatibility issue with iles:
https://github.com/ElMassimo/iles/blob/4618f4be7118c06324d74d87d35ba73c0767369b/packages/iles/src/node/cli.ts#L11
@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 6e6ef71
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62bb34a9c86aa80008ac924c

@patak-dev patak-dev merged commit cbefc63 into vitejs:main Jun 28, 2022
@patak-dev
Copy link
Member

Amazing, leaving a run of vite-ecosystem-ci after this change for reference https://github.com/vitejs/vite-ecosystem-ci/actions/runs/2578145395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants