Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build command fails in Windows #9329

Merged
merged 1 commit into from Jul 24, 2022
Merged

fix: build command fails in Windows #9329

merged 1 commit into from Jul 24, 2022

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Jul 23, 2022 •
edited

Description

Running pnpm run build in Windows fails: the scripts/patchCJS.ts module needs call process.exit with process.exit(0).

I reported this here: #8348 (comment).

closes #9328

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 8cabdd7 into vitejs:main Jul 24, 2022
@userquin userquin deleted the userquin/fix-windows-build branch July 24, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodatea sodatea sodatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running pnpm run build in Windows fails
3 participants
@userquin @sodatea @patak-dev