Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(optimizer): replace user defines #9548

Closed
wants to merge 2 commits into from
Closed

feat(optimizer): replace user defines #9548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49df955
feat(optimizer): replace user defines
bluwy Aug 5, 2022
5ed647c
docs: update note
bluwy Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/vite/src/node/optimizer/index.ts
View file
Open in desktop
Expand Up @@ -542,11 +542,17 @@ export async function runOptimizeDeps(
// In lib mode, we need to keep process.env.NODE_ENV untouched, so to at build
// time we replace it by __vite_process_env_NODE_ENV. This placeholder will be
// later replaced by the define plugin
const define = {
const define: Record<string, string> = {
'process.env.NODE_ENV': isBuild
? '__vite_process_env_NODE_ENV'
: JSON.stringify(process.env.NODE_ENV || config.mode)
}
// replace define eagerly without define plugin so esbuild can treeshake
// unused modules when scanning and prebundling
for (const key in config.define) {
const value = config.define[key]
define[key] = typeof value === 'string' ? value : JSON.stringify(value)
}

const platform =
ssr && config.ssr?.target !== 'webworker' ? 'node' : 'browser'
Expand Down