Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(define): don't modify string literals #9791

Closed
wants to merge 44 commits into from
Closed

feat(define): don't modify string literals #9791

wants to merge 44 commits into from

Commits on Aug 24, 2022

  1. fix(define): don't modify string literals 

    fix #9790
    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    29da61c View commit details
    Browse the repository at this point in the history

  2. test(define): verify define ignores literals

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0781d42 View commit details
    Browse the repository at this point in the history

  3. test(define): expand tests out of loop to easily identify failures

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    cf93c33 View commit details
    Browse the repository at this point in the history

  4. test(define): verify define ignores nested string of all quote types

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    ed16db2 View commit details
    Browse the repository at this point in the history

  5. fix(define): don't modify string literals in ssr

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    589d30b View commit details
    Browse the repository at this point in the history

  6. test(define): verify define ignores literals in ssr mode

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    603073c View commit details
    Browse the repository at this point in the history

  7. test(define): include tests from #9621

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    2eb1aea View commit details
    Browse the repository at this point in the history

  8. fix(define): only strip literals if special constant found

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    91c47d4 View commit details
    Browse the repository at this point in the history

  9. fix(define): remove unnecessary string replace for ssr

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    2031d94 View commit details
    Browse the repository at this point in the history

  10. fix(define): only start matching if replacement needed

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    8974e65 View commit details
    Browse the repository at this point in the history

  11. fix(define): return null early if no replacements needed

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    46153b7 View commit details
    Browse the repository at this point in the history

  12. wip: test(define): more tests

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    609df10 View commit details
    Browse the repository at this point in the history

  13. wip: test(define): skip meta.env and process.env tests for now 

    The failures are unrelated to my changes, as they still occur with
my changes removed. I just need to figure out the correct way to test
these inputs.
    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f5277f0 View commit details
    Browse the repository at this point in the history

  14. wip: test(define): refactor

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    6a06d5f View commit details
    Browse the repository at this point in the history

  15. wip: test(define): fix tests for for import.meta.env

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    d83ab82 View commit details
    Browse the repository at this point in the history

  16. fix(define): prevent replacement of import.meta.env during tests

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    7319275 View commit details
    Browse the repository at this point in the history

  17. test(define): fix possibly-undefined warning

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    d875495 View commit details
    Browse the repository at this point in the history

  18. test(define): tweaks

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    89d8c29 View commit details
    Browse the repository at this point in the history

  19. chore: escape import.meta.env in vue playground

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    188fbdd View commit details
    Browse the repository at this point in the history

  20. fix(define): use object hook

    @tony19
    tony19 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e71a22c View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. fix(define): simplify workaround for import.meta.env replacement

    @tony19
    tony19 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    22a9010 View commit details
    Browse the repository at this point in the history

  2. chore(define): typo

    @tony19
    tony19 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    bb34dd1 View commit details
    Browse the repository at this point in the history

  3. test(define): fix missing backticks in multiline tests

    @tony19
    tony19 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    cbff5c6 View commit details
    Browse the repository at this point in the history

  4. test(define): remove invalid test

    @tony19
    tony19 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    2b5bf2b View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. refactor(define): move string replacement code into utils

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    75ff486 View commit details
    Browse the repository at this point in the history

  2. test(define): add playground tests

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    c5736ed View commit details
    Browse the repository at this point in the history

  3. docs(define): describe new string replacement behavior

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ae211b5 View commit details
    Browse the repository at this point in the history

  4. chore: link to vitest issue in fixme comments

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e41792a View commit details
    Browse the repository at this point in the history

  5. test(define): add playground tests

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    46a291b View commit details
    Browse the repository at this point in the history

  6. test(define): skip tests for 'process.env.NODE_ENV' until #9829 fix

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    bce6fe2 View commit details
    Browse the repository at this point in the history

  7. perf(define): don't compare id if no replacements needed

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    b40fd91 View commit details
    Browse the repository at this point in the history

  8. chore: fix docs comment for replaceInCode

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    2e9460d View commit details
    Browse the repository at this point in the history

  9. fix(client-inject): don't modify string literals 

    fix #9829
    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    0383606 View commit details
    Browse the repository at this point in the history

  10. test(client-inject): add unit tests

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    1303424 View commit details
    Browse the repository at this point in the history

  11. test: update snapshots for client-inject tests

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    59c2432 View commit details
    Browse the repository at this point in the history

  12. test(client-inject): verify replaces template literal expression

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    60c8d4b View commit details
    Browse the repository at this point in the history

  13. revert: "test(define): skip tests for 'process.env.NODE_ENV' until #9829 

     fix"

This reverts commit bce6fe2.
    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e3dd331 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into fix/define-must-ignore-strings

    @tony19
    tony19 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e8a3f24 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Merge branch 'main' into fix/define-must-ignore-strings

    @tony19
    tony19 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    87b7b16 View commit details
    Browse the repository at this point in the history

  2. chore(define): remove workaround for vitest#1941 

    As of #9985, Vite is using Vitest 0.23.1, which fixed the issue.
    @tony19
    tony19 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    43d21c2 View commit details
    Browse the repository at this point in the history

  3. docs(define): update expected version

    @tony19
    tony19 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    39bd627 View commit details
    Browse the repository at this point in the history

  4. test(util): verify replaceInCode ignores string literals/comments

    @tony19
    tony19 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    1df6fa4 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Merge branch 'main' into fix/define-must-ignore-strings

    @tony19
    tony19 committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    60c4aee View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Merge branch 'main' into fix/define-must-ignore-strings

    @tony19
    tony19 committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    308d640 View commit details
    Browse the repository at this point in the history