Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test coverage #1603

Merged
merged 21 commits into from
Jun 29, 2023
Merged

Unit test coverage #1603

merged 21 commits into from
Jun 29, 2023

Conversation

keller-mark
Copy link
Member

@keller-mark keller-mark commented Jun 16, 2023

Fixes #145
Fixes #1599
Fixes #1498
Fixes #1559
Fixes #1512

Background

Change List

  • Upgrade vitest
  • Use vitest workspaces; run unit tests once at root of repo rather than independently per sub-package https://vitest.dev/guide/workspace.html
  • Configure coverage reporting in vite.config.js
  • Add github action to comment on PRs with any changes in coverage
  • Upgrade pnpm setup github action (Note: not directly related to the addition of unit test coverage)
  • Specify shell: bash to fix unit test execution on Windows in github actions
  • Clean up test.sh script
  • Clean up packages/vit-s/schemas JSON schema files that are no longer used
  • Upgrade to PNPM v8 in README and github actions

Checklist

  • Ensure PR works with all demos on the dev.vitessce.io homepage
  • Open (draft) PR's into vitessce-python and vitessce-r if this is a release PR
  • Documentation added or updated

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

Size Change: -45 B (0%)

Total Size: 11.3 MB

ℹ️ View Unchanged
Filename Size Change
./packages/main/prod/dist/deflate-********.js 243 B 0 B
./packages/main/prod/dist/hglib-********.js 4.34 MB 0 B
./packages/main/prod/dist/index-********.js 6.87 MB -45 B (0%)
./packages/main/prod/dist/index.min.js 590 B 0 B
./packages/main/prod/dist/jpeg-********.js 15.3 kB 0 B
./packages/main/prod/dist/lerc-********.js 47.2 kB 0 B
./packages/main/prod/dist/lzw-********.js 2.1 kB 0 B
./packages/main/prod/dist/packbits-********.js 576 B 0 B
./packages/main/prod/dist/pako.esm-********.js 68.6 kB 0 B
./packages/main/prod/dist/raw-********.js 168 B 0 B
./packages/main/prod/dist/webimage-********.js 872 B 0 B

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.28% 8541 / 11051
🔵 Statements 77.28% 8541 / 11051
🔵 Functions 65.03% 253 / 389
🔵 Branches 78.75% 823 / 1045
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/vit-s/src/state/hooks.js 59.31% 100% 29.72% 59.31% 53-63, 65-72, 74-86, 95-99, 116-122, 163-167, 200-225, 228-246, 254-255, 272-334, 349-353, 369-377, 380, 399-424, 433-434, 450-466, 482-503, 564-565, 574-575, 584-585, 594-595, 604-605, 614-620, 628-629
Generated in workflow #2866

@keller-mark keller-mark changed the title Turn on unit test coverage Unit test coverage Jun 18, 2023
@keller-mark keller-mark marked this pull request as ready for review June 18, 2023 19:17
@keller-mark
Copy link
Member Author

Note: bundle size check will fail due to differing pnpm-lock files and pnpm versions on main vs. in this PR

@keller-mark keller-mark merged commit 60084cd into main Jun 29, 2023
7 checks passed
@keller-mark keller-mark deleted the keller-mark/coverage branch June 29, 2023 17:12
@keller-mark keller-mark mentioned this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant