Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Golang Dependencies #15942

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Upgrade the Golang Dependencies #15942

merged 2 commits into from
Jun 3, 2024

Conversation

vitess-bot
Copy link
Contributor

This Pull Request updates all the Golang dependencies to their latest version using go get -u ./....

cc @vitessio/release

@vitess-bot vitess-bot added Component: General Changes throughout the code base go Type: Dependencies Dependency updates labels May 15, 2024
@vitess-bot vitess-bot requested a review from a team May 15, 2024 00:14
Copy link
Contributor

vitess-bot bot commented May 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 15, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.25%. Comparing base (bec711b) to head (3b9b9ed).
Report is 5 commits behind head on main.

Files Patch % Lines
go/vtbench/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15942      +/-   ##
==========================================
+ Coverage   68.23%   68.25%   +0.02%     
==========================================
  Files        1541     1541              
  Lines      197187   197404     +217     
==========================================
+ Hits       134546   134741     +195     
- Misses      62641    62663      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 15, 2024
Signed-off-by: GitHub <noreply@github.com>
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust the bots. Skynet is not real.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor

The upgrade of grpc caused some static checks to fail. Muted those in 3b9b9ed.

Failure excerpt:

Error: go/vtbench/client.go:87:24: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
			return append(opts, grpc.WithBlock()), nil
			                    ^
Error: go/vtbench/client.go:122:24: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
			return append(opts, grpc.WithBlock()), nil
			                    ^
Error: go/vt/grpcclient/client.go:145:9: SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	return grpc.DialContext(ctx, target, newopts...)
	       ^
Error: go/vt/grpcoptionaltls/server_test.go:100:16: SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
		conn, err := grpc.DialContext(ctx, addr, dialOpt)
		             ^
Error: go/vt/topo/etcd2topo/server.go:144:34: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
		DialOptions: []grpc.DialOption{grpc.WithBlock()},
		                               ^
Error: go/vt/vtadmin/grpcserver/server_test.go:67:15: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	conn, err := grpc.Dial(lis.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock())

@systay systay merged commit faa2e2e into main Jun 3, 2024
181 checks passed
@systay systay deleted the upgrade-go-deps-on-main branch June 3, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base go Type: Dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants