Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vitest-dev/vscode #12

Merged
merged 14 commits into from Mar 12, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 3, 2024

This PR adds Vitest VS Code extension https://github.com/vitest-dev/vscode.

Little summary of the repo and tests:

I think we can wait this PR until E2E is setup on vscode extension repo, but I just wanted to explore ecosystem-ci beforehand.

Copy link

stackblitz bot commented Mar 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

tests/vitest-vscode.ts Outdated Show resolved Hide resolved
@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Mar 4, 2024

I verified the CI on my fork:
https://github.com/hi-ogawa/vitest-ecosystem-ci/actions/runs/8135294958/job/22229582638#step:8:92

I doesn't look flaky on vscode repo's PR vitest-dev/vscode#276, but I just saw one failure in https://github.com/hi-ogawa/vitest-ecosystem-ci/actions/runs/8135259673/job/22229493916#step:8:201
Hopefully, it's not bothering right now, so I think we can go with this. If it turns out to be flaky, I'll investigate it.

Actually it looks flaky. For now, I added retry and it looks better, but I might need to dig into this.

@hi-ogawa hi-ogawa marked this pull request as ready for review March 4, 2024 03:14
tests/vitest-vscode.ts Outdated Show resolved Hide resolved
@AriPerkkio AriPerkkio merged commit 12d1026 into vitest-dev:main Mar 12, 2024
1 check passed
@hi-ogawa hi-ogawa deleted the feat-vscode-extension branch March 12, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants