fix: respect transformMode when resolving id (#1506)

* fix: consider transform mode when resolving ids

* test: testing resolveId

* chore: cleanup

* chore: use importer to get transform mode when resolving id

* chore: update lockfile

packages/vite-node/src/server.ts

@@ -54,7 +54,8 @@ export class ViteNodeServer {
   async resolveId(id: string, importer?: string): Promise<ViteNodeResolveId | null> {
     if (importer && !importer.startsWith(this.server.config.root))
       importer = join(this.server.config.root, importer)
-    return this.server.pluginContainer.resolveId(id, importer, { ssr: true })
+    const mode = (importer && this.getTransformMode(importer)) || 'ssr'
+    return this.server.pluginContainer.resolveId(id, importer, { ssr: mode === 'ssr' })
   }
 
   async fetchModule(id: string): Promise<FetchResult> {

test/vite-node/package.json

@@ -0,0 +1,13 @@
+{
+  "name": "@vitest/test-vite-node",
+  "private": true,
+  "scripts": {
+    "test": "vitest",
+    "coverage": "vitest run --coverage"
+  },
+  "devDependencies": {
+    "vite": "^2.9.10",
+    "vite-node": "workspace:*",
+    "vitest": "workspace:*"
+  }
+}

test/vite-node/test/server.test.ts

@@ -0,0 +1,31 @@
+import type { ViteDevServer } from 'vite'
+import { ViteNodeServer } from 'vite-node/server'
+import { describe, expect, test, vi } from 'vitest'
+
+const mockDevServer = (options: any = {}) => {
+  return options as ViteDevServer
+}
+
+describe('server works correctly', async () => {
+  test('resolve id considers transform mode', async () => {
+    const resolveId = vi.fn()
+
+    const vnServer = new ViteNodeServer(mockDevServer({
+      pluginContainer: { resolveId },
+      config: {
+        root: '/',
+      },
+    }), {
+      transformMode: {
+        web: [/web/],
+        ssr: [/ssr/],
+      },
+    })
+
+    await vnServer.resolveId('/path', '/web path')
+    expect(resolveId).toHaveBeenCalledWith('/path', '/web path', { ssr: false })
+
+    await vnServer.resolveId('/ssr', '/ssr path')
+    expect(resolveId).toHaveBeenCalledWith('/ssr', '/ssr path', { ssr: true })
+  })
+})

test/vite-node/vitest.config.ts

@@ -0,0 +1,7 @@
+import { defineConfig } from 'vitest/config'
+
+export default defineConfig({
+  test: {
+    clearMocks: true,
+  },
+})