fix: define default exports properties as named exports for ESM compa…

…tibility (#1979)
vitest-dev · Sep 5, 2022 · 5b760b0 · 5b760b0
1 parent a98c845
commit 5b760b0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/packages/vite-node/src/client.ts b/packages/vite-node/src/client.ts
@@ -4,7 +4,7 @@ import vm from 'vm'
 import { dirname, extname, isAbsolute, resolve } from 'pathe'
 import { isNodeBuiltin } from 'mlly'
 import createDebug from 'debug'
-import { getType, isPrimitive, mergeSlashes, normalizeModuleId, normalizeRequestId, slash, toFilePath } from './utils'
+import { isPrimitive, mergeSlashes, normalizeModuleId, normalizeRequestId, slash, toFilePath } from './utils'
 import type { HotContext, ModuleCache, ViteNodeRunnerOptions } from './types'
 
 const debugExecute = createDebug('vite-node:client:execute')
@@ -404,14 +404,7 @@ function exportAll(exports: any, sourceModule: any) {
   if (exports === sourceModule)
     return
 
-  const type = getType(sourceModule)
-  if (type !== 'Object' && type !== 'Module')
-    return
-
-  const constructor = sourceModule.constructor?.name
-
-  // allow only plain objects and modules (modules don't have name)
-  if (constructor && constructor !== 'Object')
+  if (typeof sourceModule !== 'object' || Array.isArray(sourceModule) || !sourceModule)
     return
 
   for (const key in sourceModule) {

diff --git a/packages/vite-node/src/utils.ts b/packages/vite-node/src/utils.ts
@@ -9,10 +9,6 @@ export function slash(str: string) {
   return str.replace(/\\/g, '/')
 }
 
-export function getType(value: unknown): string {
-  return Object.prototype.toString.apply(value).slice(8, -1)
-}
-
 export function mergeSlashes(str: string) {
   return str.replace(/\/\//g, '/')
 }

diff --git a/test/core/test/module.test.ts b/test/core/test/module.test.ts
@@ -50,7 +50,7 @@ it('arrays-cjs', () => {
 it('class-cjs', () => {
   expect(classCjs.default).toEqual({ variable: 1, Test: expect.any(Function) })
   expect(classCjs.default).toBeInstanceOf(classCjs.Test)
-  expect(classCjs).not.toHaveProperty('variable')
+  expect(classCjs, 'for compat with ESM it also defines props on Module').toHaveProperty('variable')
 })
 
 it('should work when using esm module', () => {