fix(vite-node): fix isValidNodeImport to check "type": "module" first (#5416)

Author: hi-ogawa

packages/vite-node/src/externalize.ts

@@ -61,16 +61,16 @@ async function isValidNodeImport(id: string) {
   if (extension !== '.js')
     return false
 
-  if (/\.(\w+-)?esm?(-\w+)?\.js$|\/(esm?)\//.test(id))
-    return false
-
   id = id.replace('file:///', '')
 
   const package_ = await findNearestPackageData(dirname(id))
 
   if (package_.type === 'module')
     return true
 
+  if (/\.(\w+-)?esm?(-\w+)?\.js$|\/(esm?)\//.test(id))
+    return false
+
   const code = await fsp.readFile(id, 'utf8').catch(() => '')
 
   return !ESM_SYNTAX_RE.test(code)

pnpm-lock.yaml

@@ -0,0 +1,4 @@
+// esm/index.js was detected as isValidNodeImport(id) = false
+// event if package.json has type = module,
+// which causes dual package hazard when other external esm import esm/index.js.
+export const data = {}

test/vite-node/deps/dep1/esm/index.js

@@ -0,0 +1,5 @@
+{
+  "name": "@vitest/test-dep1",
+  "type": "module",
+  "exports": "./esm/index.js"
+}

test/vite-node/deps/dep1/package.json

@@ -0,0 +1 @@
+export { data } from '@vitest/test-dep1'

test/vite-node/deps/dep2/index.js

@@ -0,0 +1,8 @@
+{
+  "name": "@vitest/test-dep2",
+  "type": "module",
+  "exports": "./index.js",
+  "peerDependencies": {
+    "@vitest/test-dep1": "*"
+  }
+}

test/vite-node/deps/dep2/package.json

@@ -11,6 +11,8 @@
   },
   "devDependencies": {
     "@types/inquirer": "^9.0.3",
+    "@vitest/test-dep1": "file:./deps/dep1",
+    "@vitest/test-dep2": "file:./deps/dep2",
     "execa": "^6.1.0",
     "inquirer": "^9.2.7",
     "vite-node": "workspace:*",

test/vite-node/package.json

@@ -0,0 +1,12 @@
+import { expect, test } from 'vitest'
+
+// @ts-expect-error no ts
+import * as dep1 from '@vitest/test-dep1'
+
+// @ts-expect-error no ts
+import * as dep2 from '@vitest/test-dep2'
+
+test('no dual package hazard by externalizing esm deps by default', async () => {
+  dep1.data.hello = 'world'
+  expect(dep2.data.hello).toBe('world')
+})