New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-node): fix isValidNodeImport
to check "type": "module"
first
#5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
changed the title
fix(vite-node): fix
fix(vite-node): fix Mar 22, 2024
isValidNodeImport
to check type === "module"
firstisValidNodeImport
to check "type": "module"
first
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dunqing
approved these changes
Mar 23, 2024
sheremet-va
approved these changes
Mar 26, 2024
renovate bot
added a commit
to solid-design-system/solid
that referenced
this pull request
Apr 11, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vite-node](https://togithub.com/vitest-dev/vitest/blob/main/packages/vite-node#readme) ([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vite-node)) | [`1.4.0` -> `1.5.0`](https://renovatebot.com/diffs/npm/vite-node/1.4.0/1.5.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/vite-node/1.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite-node/1.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite-node/1.4.0/1.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite-node/1.4.0/1.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest (vite-node)</summary> ### [`v1.5.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.4.0...v1.5.0) ##### 🚀 Features - Add configuration for diff truncation - by [@​willieho](https://togithub.com/willieho) in [vitest-dev/vitest#5073 and [vitest-dev/vitest#5333 [<samp>(6797b)</samp>](https://togithub.com/vitest-dev/vitest/commit/6797b041) - Remove unrelated noise from diff for toMatchObject() - by [@​geersch](https://togithub.com/geersch) in [vitest-dev/vitest#5364 [<samp>(99276)</samp>](https://togithub.com/vitest-dev/vitest/commit/99276399) - Allow custom host for --inspect and --inspect-brk - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#5509 [<samp>(61572)</samp>](https://togithub.com/vitest-dev/vitest/commit/6157282c) - **coverage**: V8 to ignore empty lines, comments, types - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#5457 [<samp>(10b89)</samp>](https://togithub.com/vitest-dev/vitest/commit/10b89713) ##### 🐞 Bug Fixes - `describe` calls not taking generic type parameters - by [@​aryaemami59](https://togithub.com/aryaemami59) in [vitest-dev/vitest#5415 [<samp>(16bac)</samp>](https://togithub.com/vitest-dev/vitest/commit/16bacfab) - Prevent hang when `process` is mocked - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#5430 [<samp>(0ec4d)</samp>](https://togithub.com/vitest-dev/vitest/commit/0ec4d0e0) - Don't check for "node:internal/console/" in console interceptor in case the environment is not Node.js - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(87d36)</samp>](https://togithub.com/vitest-dev/vitest/commit/87d36a7a) - The value received by toMatch should be a string - by [@​btea](https://togithub.com/btea) in [vitest-dev/vitest#5428 [<samp>(67485)</samp>](https://togithub.com/vitest-dev/vitest/commit/674851ca) - Increase stack trace limit for location, don't hardcode suite position - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#5518 [<samp>(04b23)</samp>](https://togithub.com/vitest-dev/vitest/commit/04b234d1) - **benchmark**: - Run benchmark suites sequentially - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [vitest-dev/vitest#5444 [<samp>(1f548)</samp>](https://togithub.com/vitest-dev/vitest/commit/1f548340) - Fix benchmark summary of single bench suite - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [vitest-dev/vitest#5489 [<samp>(db981)</samp>](https://togithub.com/vitest-dev/vitest/commit/db98145f) - Table reporter for non TTY output - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [vitest-dev/vitest#5484 [<samp>(bea23)</samp>](https://togithub.com/vitest-dev/vitest/commit/bea234b1) - **expect**: - Fix `toHaveBeenNthCalledWith` error message when not called - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [vitest-dev/vitest#5420 [<samp>(e5253)</samp>](https://togithub.com/vitest-dev/vitest/commit/e5253de4) - **types**: - Pass correct type for suite factory - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#5437 [<samp>(26718)</samp>](https://togithub.com/vitest-dev/vitest/commit/26718eb5) - **utils**: - Fix object diff with getter only property - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [vitest-dev/vitest#5466 [<samp>(366d9)</samp>](https://togithub.com/vitest-dev/vitest/commit/366d97c3) - **vite-node**: - Fix `isValidNodeImport` to check `"type": "module"` first - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [vitest-dev/vitest#5416 [<samp>(6fb15)</samp>](https://togithub.com/vitest-dev/vitest/commit/6fb15280) - **vitest**: - Correctly send console events when state changes - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(3463f)</samp>](https://togithub.com/vitest-dev/vitest/commit/3463f9bb) - Initiate FakeTimers on demand - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#5450 [<samp>(e4e93)</samp>](https://togithub.com/vitest-dev/vitest/commit/e4e939ba) - Check unhighlighted code for code frame line limit - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [vitest-dev/vitest#5465 [<samp>(6ae7e)</samp>](https://togithub.com/vitest-dev/vitest/commit/6ae7eaa2) - Correctly filter by parent folder - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#5408 [<samp>(91b06)</samp>](https://togithub.com/vitest-dev/vitest/commit/91b06cce) - Close inspector immediately if run is canceled - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#5519 [<samp>(b8006)</samp>](https://togithub.com/vitest-dev/vitest/commit/b80062d7) - **workspace**: - Set CWD to config directory, allow overriding local .env - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#5476 [<samp>(d4003)</samp>](https://togithub.com/vitest-dev/vitest/commit/d4003882) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.4.0...v1.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone Europe/Berlin, Automerge - "after 10pm every weekday,before 5am every weekday" in timezone Europe/Berlin. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/solid-design-system/solid). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
6 tasks
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in #5404 (comment), current
shouldExternalize
andisValidNodeImport
heuristics don't seem optimal.By flipping the condition of
"type": "module"
check and/esm?/.test(id)
(which is whatmlly
has been doing), I think this will save legitimate ESM from inlined due to the file name having.../esm/...
like the case ofwagmi
https://publint.dev/wagmi@2.5.11.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.