feat: check for moduleDirectories when externalizing dependency

vitest-dev · May 25, 2023 · bab1cbe · bab1cbe
1 parent d845d5e
commit bab1cbe
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/packages/vite-node/src/externalize.ts b/packages/vite-node/src/externalize.ts
@@ -114,8 +114,11 @@ async function _shouldExternalize(
   if (matchExternalizePattern(id, options?.external))
     return id
 
-  const isNodeModule = id.includes('/node_modules/')
-  const guessCJS = isNodeModule && options?.fallbackCJS
+  const moduleDirectories = options?.moduleDirectories || ['/node_modules/']
+  const isLibraryModule = moduleDirectories.some(dir =>
+    dir instanceof RegExp ? dir.test(id) : id.includes(dir),
+  )
+  const guessCJS = isLibraryModule && options?.fallbackCJS
   id = guessCJS ? (guessCJSversion(id) || id) : id
 
   if (matchExternalizePattern(id, defaultInline))
@@ -124,7 +127,7 @@ async function _shouldExternalize(
     return id
 
   const isDist = id.includes('/dist/')
-  if ((isNodeModule || isDist) && await isValidNodeImport(id))
+  if ((isLibraryModule || isDist) && await isValidNodeImport(id))
     return id
 
   return false