fix(web-worker): ensure event listener functions are bound correctly (#…

…1487)
vitest-dev · Jun 14, 2022 · c6f2346 · c6f2346
1 parent 2e16fb9
commit c6f2346
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/packages/web-worker/src/pure.ts b/packages/web-worker/src/pure.ts
@@ -102,8 +102,8 @@ export function defineWebWorker() {
           this.inside.emit(event.type, event)
           return true
         },
-        addEventListener: this.inside.on,
-        removeEventListener: this.inside.off,
+        addEventListener: this.inside.on.bind(this.inside),
+        removeEventListener: this.inside.off.bind(this.inside),
         postMessage: (data) => {
           this.outside.emit('message', { data })
         },

diff --git a/test/web-worker/src/eventListenerWorker.ts b/test/web-worker/src/eventListenerWorker.ts
@@ -0,0 +1,3 @@
+self.addEventListener('message', (e) => {
+  self.postMessage(`${e.data} world`)
+})
diff --git a/test/web-worker/test/init.test.ts b/test/web-worker/test/init.test.ts
@@ -1,6 +1,7 @@
 import { expect, it } from 'vitest'
 
 import MyWorker from '../src/worker?worker'
+import MyEventListenerWorker from '../src/eventListenerWorker?worker'
 
 const testWorker = (worker: Worker) => {
   return new Promise<void>((resolve) => {
@@ -23,6 +24,12 @@ it('simple worker', async () => {
   await testWorker(new MyWorker())
 })
 
+it('event listener worker', async () => {
+  expect.assertions(1)
+
+  await testWorker(new MyEventListenerWorker())
+})
+
 it('can test workers several times', async () => {
   expect.assertions(1)