fix: really disable deps optimization #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
6 tasks
patak-dev
reviewed
Apr 5, 2022
Comment on lines
+82
to
+84
| optimizeDeps: { | ||
| entries: [], | ||
| }, |
There was a problem hiding this comment.
I wonder if we should add an optimizeDeps: false option in Vite (this works totally fine, just thinking that we could be more explicit)
There was a problem hiding this comment.
I'd like to see that (was a bit surprised this wasn't an option in Vite)
There was a problem hiding this comment.
I'll do a PR and we can talk about it in the next meeting 👍🏼
chaii3
pushed a commit
to chaii3/vitest
that referenced
this pull request
May 13, 2022
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #485