Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: really disable deps optimization #1104

Merged
merged 1 commit into from Apr 5, 2022
Merged

fix: really disable deps optimization #1104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/vitest/src/node/plugins/index.ts
View file
Open in desktop
Expand Up @@ -79,6 +79,9 @@ export async function VitestPlugin(options: UserConfig = {}, ctx = new Vitest())
},
// disable deps optimization
cacheDir: undefined,
optimizeDeps: {
entries: [],
},
Comment on lines +82 to +84
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add an optimizeDeps: false option in Vite (this works totally fine, just thinking that we could be more explicit)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see that (was a bit surprised this wasn't an option in Vite)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a PR and we can talk about it in the next meeting 👍🏼

}
},
async configResolved(viteConfig) {
Expand Down