fix: remove invalid xml characters in junit reporter output (fix #1144) #1145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line in data.ts contains two control characters, visible in vs code:
That line is scrubbed by the new
removeInvalidXMLCharacters
function, ensuring that the XML output doesn't contain the control characters.Reproduction
Reproduction StackBlitz.
Let the tests run and open test_result/junit.xml. The file contains disallowed characters, specifically in the tag.
You can use any XML validator to check, such as the one from w3schools.