fix: birpc using safe timers #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Not very sure about the perf impact but I think we could have it for now |
antfu
approved these changes
May 27, 2022
|
After this PR, the unit test of Element Plus failed... I don't know why. |
GabrielBuragev
added a commit
to beamer-bridge/beamer
that referenced
this pull request
Jan 19, 2023
Seems like there is a weird issue with vitest version <0.12.10 when using mocked timers inside tests. More specifically, this issue: vitest-dev/vitest#1379 This commit updates the version of vitest to a version which contains a fix for this issue.
GabrielBuragev
added a commit
to beamer-bridge/beamer
that referenced
this pull request
Jan 19, 2023
Seems like there is a weird issue with vitest version <0.12.10 when using mocked timers inside tests. More specifically, this issue: vitest-dev/vitest#1379 This commit updates the version of vitest to a version which contains a fix for this issue.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1154