Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-worker): ensure event listener functions are bound correctly #1487

Merged
merged 1 commit into from Jun 14, 2022
Merged

fix(web-worker): ensure event listener functions are bound correctly #1487

merged 1 commit into from Jun 14, 2022

Conversation

freshollie
Copy link
Contributor

Previously .addEventListener would throw an error in the worker context:

TypeError: Cannot read properties of undefined (reading 'message')

Seems this was due to the unbound method assignment. Added a test to prove it

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 65dda3a
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62a880daebd28200089653f9
😎 Deploy Preview https://deploy-preview-1487--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit c6f2346 into vitest-dev:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants