Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VITEST_POOL_ID cannot be the same between different running specs #1531

Merged
merged 3 commits into from Jun 24, 2022

Conversation

sheremet-va
Copy link
Member

Fixes VITETS_POOL_ID logic.

@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b8ed92
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62b572f1c63cb9000805988d
😎 Deploy Preview https://deploy-preview-1531--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va
Copy link
Member Author

@Aslemammad tests are not exiting, if I import tinypool directly inside a worker 🤔

@Aslemammad
Copy link
Member

@sheremet-va Can I continue the work here?

@sheremet-va
Copy link
Member Author

@sheremet-va Can I continue the work here?

Sure

@Aslemammad
Copy link
Member

@sheremet-va Could you please try updating tinypool (patch, I released)

@sheremet-va
Copy link
Member Author

@sheremet-va Could you please try updating tinypool (patch, I released)

updated

@sheremet-va sheremet-va merged commit d9c96fa into vitest-dev:main Jun 24, 2022
@sheremet-va sheremet-va deleted the feat/tinypool-id branch June 24, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants