Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add throat when running spec files #1482

Closed
wants to merge 2 commits into from

Conversation

sheremet-va
Copy link
Member

Fixes VITETS_POOL_ID logic.

I noticed no performance differences with this.

I think this might also help with segfalts and Node errors? I have a feeling that running them all might cause it, but I don't have anything to back up that claim.

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 324e69b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62a836cf235e700009763a6c
😎 Deploy Preview https://deploy-preview-1482--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va
Copy link
Member Author

Also will reuse p-limit for #1212 in the PR after this

@sheremet-va sheremet-va marked this pull request as draft June 14, 2022 07:02
@sheremet-va
Copy link
Member Author

@Aslemammad maybe we can add a possibility to hook up into the internal tinypool queue? We need to generate VITEST_POOL_ID based on the running workers: #1469 (comment) (only not used IDs should be used)

@Aslemammad
Copy link
Member

@sheremet-va It's possible! I can work on it after my exams next week! Is it okay?

@sheremet-va
Copy link
Member Author

@sheremet-va It's possible! I can work on it after my exams next week! Is it okay?

Yes, ofc, that would be lovely. Good luck on your exams!

@Aslemammad
Copy link
Member

@sheremet-va Sure, thank you so much!

@sheremet-va
Copy link
Member Author

Continued in #1531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants