feat: support --segfault-retry=3
#1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheremet-va
requested changes
Aug 15, 2022
| main() | ||
|
|
||
| async function start(args: string[]) { | ||
| const child = execa('node', [fileURLToPath(ENTRY), ...args], { |
There was a problem hiding this comment.
Doesn't it hurt performance for "--segfault-retry=1" that we always starts a child process? Shouldn't we just import ./cli.mjs in this case?
There was a problem hiding this comment.
Hm, but we can't show useful error message that way 🤔
I guess it's ok for now.
There was a problem hiding this comment.
I didn't count how many times we invoke vitest in our test, but at the high level, it doesn't make CI time increase. Using this would allow us to provide information about the segfault reasoning and issue link.
sheremet-va
approved these changes
Aug 15, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: vitejs/vite#9508
Changes:
--segfault-retryCLI flag andVITEST_SEGFAULT_RETRYenvCo-authored-by: tony19 tony19@users.noreply.github.com