Errors from running Vite nodejs tests

[ydcjeff]

I tried to migrate Vite nodejs tests to Vitest. Half of them passed and half failed.

I don't know how to debug this, so make a report here.

Reproduction: https://github.com/ydcjeff/vite/tree/test/vitest

Reproduction steps:

• pnpm i
• cd packages/vite && pnpm run dev
• pnpm run test-serve (2nd terminal)

Error trace:

[ydcjeff]

The last error from the screenshot can be fixed by adding exports field in totalist package.json.

The other errors still remained unfixed.

[antfu]

Try add define: { "process.env.NODE": "process.env.NODE" } in vitest.config

And add totalist to test: { deps: { inline: ['totalist'] }}}

[ydcjeff]

unfortunately, it didn't work.

[atk]

Shouldn't it be define: { "process.env.NODE": process.env.NODE }?

[vinothvk]

I am also seeing this 'Directory import xyz is not supported resolving ES Modules imported from' error
tried using deps.inline and it didn't help

[sheremet-va]

So, I found that we always replace NODE_ENV because of this: https://github.com/vitejs/vite/blob/3480f27d4db7f7ebd27164d9185e7b387762274e/packages/vite/src/node/plugins/clientInjections.ts#L52

@antfu do you have any ideas how we can bypass this? I wanted to redefine define config in Vitest plugin - instead of replacing it statically, I wanted to put them on global, so people can reassign them in tests. Right now this is impossible to do with NODE_ENV

[antfu]

We could just remove the vite:client-inject plugin in configResolve to see if it fixes the issue

[sheremet-va]

We could just remove the vite:client-inject plugin in configResolve to see if it fixes the issue

It failes, because /@vite/env depends on it:

ReferenceError: __DEFINES__ is not defined
    at C:/Users/Vladimir/Documents/git/vitest/test/core/@vite/env:16:17

[sheremet-va]

I'm not sure if this else if is really needed? Doesn't NODE_ENV get replaced by define-plugin?

[patak-dev]

Maybe we could split vite:client-inject in Vite core in two plugins so we only get __DEFINES__ for Vitest

Or actually, we could remove vite:client-inject and add a copy of it in Vitest that only injects __DEFINES__?

[sheremet-va]

Maybe we could split vite:client-inject in Vite core in two plugins so we only get __DEFINES__ for Vitest

Or actually, we could remove vite:client-inject and add a copy of it in Vitest that only injects __DEFINES__?

I like your first idea more :P

[sheremet-va]

Is this still a problem?

[ydcjeff]

This is no longer a problem since

• fix: use Vitest for unit testing, clean regex bug vitejs/vite#8040