fix(coverage): fix sourcemaps of uncovered lines #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriPerkkio
force-pushed
the
fix/uncovered-coverage-sourcemaps
branch
from
cbe0373
to
1872fd0
Compare
sheremet-va
approved these changes
Oct 8, 2022
antfu
approved these changes
Oct 8, 2022
fwouts
pushed a commit
to fwouts/previewjs
that referenced
this pull request
Oct 13, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`0.24.0` -> `0.24.1`](https://renovatebot.com/diffs/npm/vitest/0.24.0/0.24.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.24.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) ##### 🐞 Bug Fixes - Remove work-around from `istanbul-lib-instrument` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2121 - Don't show extra properties for test context - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2116 - Parse env options from comments (fix [#​1962](https://togithub.com/vitest-dev/vitest/issues/1962)) - by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#1984 - **coverage**: Fix sourcemaps of uncovered lines - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2122 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMC4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
marvinruder
pushed a commit
to marvinruder/rating-tracker-frontend
that referenced
this pull request
Oct 15, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/coverage-c8](https://togithub.com/vitest-dev/vitest) | [`^0.24.0` -> `^0.24.3`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-c8/0.24.0/0.24.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.24.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ##### 🐞 Bug Fixes - **build**: Build packages before publishing - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(3c4a2)</samp>](https://togithub.com/vitest-dev/vitest/commit/3c4a277e) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ### [`v0.24.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ##### 🚀 Features - **ui**: Add tests summary in the dashboard - by [@​webfansplz](https://togithub.com/webfansplz) and [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2133 ##### 🐞 Bug Fixes - **bench**: Throw root cause - by [@​azaleta](https://togithub.com/azaleta) and [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#2137 - **browser**: Working again - by [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2143 - **coverage**: Reduce size of leftover v8 reports - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2144 - **vite-node**: Init the debugger ahead of time to ensure that load dumped code work as expected (fix [#​2126](https://togithub.com/vitest-dev/vitest/issues/2126)) - by [@​await-ovo](https://togithub.com/await-ovo) in [vitest-dev/vitest#2127 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ### [`v0.24.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) ##### 🐞 Bug Fixes - Remove work-around from `istanbul-lib-instrument` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2121 - Don't show extra properties for test context - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2116 - Parse env options from comments (fix [#​1962](https://togithub.com/vitest-dev/vitest/issues/1962)) - by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#1984 - **coverage**: Fix sourcemaps of uncovered lines - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2122 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/marvinruder/rating-tracker-frontend). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzNy4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
marvinruder
pushed a commit
to marvinruder/rating-tracker-frontend
that referenced
this pull request
Oct 15, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`^0.24.0` -> `^0.24.3`](https://renovatebot.com/diffs/npm/vitest/0.24.0/0.24.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.24.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ##### 🐞 Bug Fixes - **build**: Build packages before publishing - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(3c4a2)</samp>](https://togithub.com/vitest-dev/vitest/commit/3c4a277e) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ### [`v0.24.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ##### 🚀 Features - **ui**: Add tests summary in the dashboard - by [@​webfansplz](https://togithub.com/webfansplz) and [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2133 ##### 🐞 Bug Fixes - **bench**: Throw root cause - by [@​azaleta](https://togithub.com/azaleta) and [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#2137 - **browser**: Working again - by [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2143 - **coverage**: Reduce size of leftover v8 reports - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2144 - **vite-node**: Init the debugger ahead of time to ensure that load dumped code work as expected (fix [#​2126](https://togithub.com/vitest-dev/vitest/issues/2126)) - by [@​await-ovo](https://togithub.com/await-ovo) in [vitest-dev/vitest#2127 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ### [`v0.24.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) ##### 🐞 Bug Fixes - Remove work-around from `istanbul-lib-instrument` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2121 - Don't show extra properties for test context - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2116 - Parse env options from comments (fix [#​1962](https://togithub.com/vitest-dev/vitest/issues/1962)) - by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#1984 - **coverage**: Fix sourcemaps of uncovered lines - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2122 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/marvinruder/rating-tracker-frontend). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzNy4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
marvinruder
pushed a commit
to marvinruder/rating-tracker
that referenced
this pull request
Nov 12, 2022
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/coverage-c8](https://togithub.com/vitest-dev/vitest) | [`^0.24.0` -> `^0.24.3`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-c8/0.24.0/0.24.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.24.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ##### 🐞 Bug Fixes - **build**: Build packages before publishing - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(3c4a2)</samp>](https://togithub.com/vitest-dev/vitest/commit/3c4a277e) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ### [`v0.24.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ##### 🚀 Features - **ui**: Add tests summary in the dashboard - by [@​webfansplz](https://togithub.com/webfansplz) and [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2133 ##### 🐞 Bug Fixes - **bench**: Throw root cause - by [@​azaleta](https://togithub.com/azaleta) and [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#2137 - **browser**: Working again - by [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2143 - **coverage**: Reduce size of leftover v8 reports - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2144 - **vite-node**: Init the debugger ahead of time to ensure that load dumped code work as expected (fix [#​2126](https://togithub.com/vitest-dev/vitest/issues/2126)) - by [@​await-ovo](https://togithub.com/await-ovo) in [vitest-dev/vitest#2127 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ### [`v0.24.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) ##### 🐞 Bug Fixes - Remove work-around from `istanbul-lib-instrument` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2121 - Don't show extra properties for test context - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2116 - Parse env options from comments (fix [#​1962](https://togithub.com/vitest-dev/vitest/issues/1962)) - by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#1984 - **coverage**: Fix sourcemaps of uncovered lines - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2122 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/marvinruder/rating-tracker-frontend). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzNy4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
marvinruder
pushed a commit
to marvinruder/rating-tracker
that referenced
this pull request
Nov 12, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vitest](https://togithub.com/vitest-dev/vitest) | [`^0.24.0` -> `^0.24.3`](https://renovatebot.com/diffs/npm/vitest/0.24.0/0.24.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.24.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.3) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ##### 🐞 Bug Fixes - **build**: Build packages before publishing - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(3c4a2)</samp>](https://togithub.com/vitest-dev/vitest/commit/3c4a277e) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.2...v0.24.3) ### [`v0.24.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.2) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ##### 🚀 Features - **ui**: Add tests summary in the dashboard - by [@​webfansplz](https://togithub.com/webfansplz) and [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2133 ##### 🐞 Bug Fixes - **bench**: Throw root cause - by [@​azaleta](https://togithub.com/azaleta) and [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#2137 - **browser**: Working again - by [@​userquin](https://togithub.com/userquin) in [vitest-dev/vitest#2143 - **coverage**: Reduce size of leftover v8 reports - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2144 - **vite-node**: Init the debugger ahead of time to ensure that load dumped code work as expected (fix [#​2126](https://togithub.com/vitest-dev/vitest/issues/2126)) - by [@​await-ovo](https://togithub.com/await-ovo) in [vitest-dev/vitest#2127 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.1...v0.24.2) ### [`v0.24.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v0.24.1) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) ##### 🐞 Bug Fixes - Remove work-around from `istanbul-lib-instrument` - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2121 - Don't show extra properties for test context - by [@​sheremet-va](https://togithub.com/sheremet-va) in [vitest-dev/vitest#2116 - Parse env options from comments (fix [#​1962](https://togithub.com/vitest-dev/vitest/issues/1962)) - by [@​nickmccurdy](https://togithub.com/nickmccurdy) in [vitest-dev/vitest#1984 - **coverage**: Fix sourcemaps of uncovered lines - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [vitest-dev/vitest#2122 ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v0.24.0...v0.24.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/marvinruder/rating-tracker-frontend). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzNy4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #2121 I noticed that sourcemaps of uncovered files' coverages are off.
$ cd test/coverage-test $ pnpm coverage:istanbul $ npx live-server ./coverageBefore:
After: