fix!: default glob #3729
Merged
fix!: default glob #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Looks good to me. I think we should have this as soon before the original breaking change gets spread wide.
As mentioned in #3530 (comment), I do think we should also improve our documentation on the Jest migration, it can be another PR tho.
|
@so1ve any thing missing from making it ready to review? |
|
@antfu I think it is ready for review now! |
I'm fine with releasing 0.33.0 with just this change. |
sheremet-va
approved these changes
Jul 5, 2023
|
...Forgot to use squash merge? |
Hehe, yeah |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3530