docs: improve globs #3737
Closed
docs: improve globs #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6 tasks
sheremet-va
approved these changes
Jul 4, 2023
dammy001
reviewed
Jul 5, 2023
| @@ -83,7 +83,7 @@ All configuration options that are not supported inside a [workspace](/guide/wor | |||
| - **Type:** `string[]` | |||
| - **Default:** `['**/__tests__/**/*.?(c|m)[jt]s?(x)', '**/?(*.){test,spec}.?(c|m)[jt]s?(x)']` | |||
|
|
|||
| Files to include in the test run, using glob pattern. | |||
| Files to include in the test run, using glob patterns. By default it looks for files in any folders named `__tests__` with the extensions `.js`,`.mjs`, `.cjs`, `.ts`, `.mts`, `.cts`, `.jsx`, and `.jsx` . It also includes files ending with `.test` or `.spec` along with files just named `test` or `spec` (before a valid extension). These patterns are compatible with Jest's default patterns, but with additional extensions. | |||
There was a problem hiding this comment.
Suggested change
| Files to include in the test run, using glob patterns. By default it looks for files in any folders named `__tests__` with the extensions `.js`,`.mjs`, `.cjs`, `.ts`, `.mts`, `.cts`, `.jsx`, and `.jsx` . It also includes files ending with `.test` or `.spec` along with files just named `test` or `spec` (before a valid extension). These patterns are compatible with Jest's default patterns, but with additional extensions. | |
| Files to include in the test run, using glob patterns. By default it looks for files in any folders named `__tests__` with the extensions `.js`,`.mjs`, `.cjs`, `.ts`, `.mts`, `.cts`, `.jsx`, and `.tsx`. It also includes files ending with `.test` or `.spec` along with files just named `test` or `spec` (before a valid extension). These patterns are compatible with Vitest default patterns but with additional extensions. |
dammy001
reviewed
Jul 5, 2023
| @@ -1372,14 +1372,15 @@ You can also pass down a path to custom binary or command name that produces the | |||
| - **Type**: `string[]` | |||
| - **Default**: `['**/?(*.){test,spec}-d.?(c|m)[jt]s?(x)']` | |||
|
|
|||
| Glob pattern for files that should be treated as test files | |||
| Files to include in typechecking test runs, using glob patterns. By default all tests inside files ending with `test-d` along with files just named `test-d` are considered type tests. | |||
There was a problem hiding this comment.
Suggested change
| Files to include in typechecking test runs, using glob patterns. By default all tests inside files ending with `test-d` along with files just named `test-d` are considered type tests. | |
| Files to include in typechecking test runs, using glob patterns. By default, all tests inside files ending with `test-d` along with files just named `test-d` are considered type tests. |
posva
reviewed
Jul 5, 2023
| @@ -83,7 +83,7 @@ All configuration options that are not supported inside a [workspace](/guide/wor | |||
| - **Type:** `string[]` | |||
| - **Default:** `['**/__tests__/**/*.?(c|m)[jt]s?(x)', '**/?(*.){test,spec}.?(c|m)[jt]s?(x)']` | |||
|
|
|||
| Files to include in the test run, using glob pattern. | |||
| Files to include in the test run, using glob patterns. By default it looks for files in any folders named `__tests__` with the extensions `.js`,`.mjs`, `.cjs`, `.ts`, `.mts`, `.cts`, `.jsx`, and `.jsx` . It also includes files ending with `.test` or `.spec` along with files just named `test` or `spec` (before a valid extension). These patterns are compatible with Jest's default patterns, but with additional extensions. | |||
There was a problem hiding this comment.
I don't think this is a good idea, as mentioned at #3530 (comment).
Let's not add this to just remove it afterward 🙃
antfu
requested changes
Jul 5, 2023
There was a problem hiding this comment.
I don't think we should move forward on this. As mentioned in #3530 (comment), I think we should revert this behavior and consider it as a regression. And if we are going to do it, I rather not document it as it will confuse users when are we will going to change it back soon.
|
Close this as we reverted this behaviour in the recent minor: #3729 Thanks for bringing this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation that I originally intended on adding to #3392