feat: export default config to expand it #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 39430cc 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6203bfc69b34ec00071405f0 😎 Browse the preview: https://deploy-preview-702--vitest-dev.netlify.app |
antfu
reviewed
Feb 8, 2022
antfu
reviewed
Feb 8, 2022
packages/vitest/src/constants.ts
Outdated
| @@ -1,11 +1,37 @@ | |||
| import { fileURLToPath } from 'url' | |||
| import { resolve } from 'pathe' | |||
| import type { UserConfig } from './types' | |||
| import { defaults as coverageDefaults } from './integrations/coverage' | |||
There was a problem hiding this comment.
We should move the default from coverage to this file, the module is running in different context.
There was a problem hiding this comment.
I've moved it there, but I still import it from here.
antfu
reviewed
Feb 8, 2022
packages/vitest/src/constants.ts
Outdated
| uiBase: '/__vitest__/', | ||
| open: true, | ||
| coverage: coverageDefaults, | ||
| } |
There was a problem hiding this comment.
We might also want to froze this object to avoid mutation on user land
antfu
approved these changes
Feb 8, 2022
antfu
reviewed
Feb 8, 2022
docs/config/index.md
Outdated
| You can retrieve Vitest's default options to expand them if needed: | ||
|
|
||
| ```ts | ||
| import { defineConfig, defaultConfig } from 'vitest' |
There was a problem hiding this comment.
They look a bit similar 😅, how about configDefaults?
Demivan
reviewed
Feb 9, 2022
sheremet-va
commented
Feb 9, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #701