fix(cli): handle run mode correctly (fix #719) #717
Conversation
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 8544bf5 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/62042046fe2e9f000803c839 😎 Browse the preview: https://deploy-preview-717--vitest-dev.netlify.app |
DerYeger
changed the title
DerYeger
changed the title
| @@ -49,6 +49,7 @@ export const configDefaults: UserConfig = Object.freeze({ | |||
| isolate: true, | |||
| watchIgnore: [/\/node_modules\//, /\/dist\//], | |||
| update: false, | |||
| run: !!process.env.CI, | |||
There was a problem hiding this comment.
The fix should be make watch default to false and handles it in CLI, /cc @sheremet-va
|
|
||
| cli | ||
| .command('[...filters]') | ||
| .action(dev) | ||
| .action(run) |
There was a problem hiding this comment.
Can we keep the original naming? I found them a bit confusing
There was a problem hiding this comment.
Since we don't really need the dev function anymore I now inlined the option overrides of vitest run.
| @@ -56,7 +56,7 @@ export async function VitestPlugin(options: UserConfig = {}, ctx = new Vitest()) | |||
| options, | |||
| ) | |||
| options.api = resolveApiConfig(options) | |||
| options.watch = options.watch && !options.run | |||
| options.watch = !options.run | |||
There was a problem hiding this comment.
Should keep the original logic.
There are some logic under dev get removed in #702, we need to bring them back
There was a problem hiding this comment.
The logic of the dev function that got removed in #702 isn't needed anymore.
It was just acting as a default value, which is now included in configDefaults.
DerYeger
force-pushed
the
fix_missing_default
branch
from
e2b2f02
to
8544bf5
Compare
Absolutely, the separate |
Closes #719